Support complex matchers in GetImplicitPermissionsForUser()#1680
Open
Support complex matchers in GetImplicitPermissionsForUser()#1680
Conversation
|
|
…chers Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
…nsForUser Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Make GetImplicitPermissionsForUser() API support all matchers
Support complex matchers in GetImplicitPermissionsForUser()
Jan 10, 2026
Member
|
@copilot fix: fix: |
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Contributor
Author
Fixed in fda114e. The test failure was caused by test files using hardcoded |
Member
|
@copilot fix: |
…rmat with goimports Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Contributor
Author
... Fixed in cc163ba. Addressed all golangci-lint issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Make GetImplicitPermissionsForUser() work for all matcher cases
Summary
Successfully enhanced
GetImplicitPermissionsForUser()to support complex matchers including:g(user, role, '*'))g(r.sub, p.sub, r.dom) || g(r.sub, p.sub, '*'))All existing tests pass, and new tests verify the complex matcher functionality works as expected.
Fixed CI test failures by moving test files from /tmp to the examples directory.
Fixed all golangci-lint issues: added periods to comments, reduced nesting complexity, and formatted with goimports.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.